OSDN Git Service

Revert "sh: add loglvl to printk_address()"
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 17 Jun 2020 14:36:32 +0000 (16:36 +0200)
committerRich Felker <dalias@libc.org>
Sat, 15 Aug 2020 02:05:07 +0000 (22:05 -0400)
This reverts commit 2deebe4d56d638269a4a728086d64de5734b460a.

printk_address() is always used as a continuation of the previous
logging, hence it should not include a log level.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rich Felker <dalias@libc.org>
arch/sh/include/asm/kdebug.h
arch/sh/kernel/dumpstack.c
arch/sh/mm/fault.c

index 9605453..de8693f 100644 (file)
@@ -12,8 +12,7 @@ enum die_val {
 };
 
 /* arch/sh/kernel/dumpstack.c */
-extern void printk_address(unsigned long address, int reliable,
-                          const char *loglvl);
+extern void printk_address(unsigned long address, int reliable);
 extern void dump_mem(const char *str, const char *loglvl,
                     unsigned long bottom, unsigned long top);
 
index a13c045..ad548fc 100644 (file)
@@ -44,9 +44,9 @@ void dump_mem(const char *str, const char *loglvl,
        }
 }
 
-void printk_address(unsigned long address, int reliable, const char *loglvl)
+void printk_address(unsigned long address, int reliable)
 {
-       printk("%s [<%p>] %s%pS\n", loglvl, (void *) address,
+       printk(" [<%p>] %s%pS\n", (void *) address,
                        reliable ? "" : "? ", (void *) address);
 }
 
@@ -118,7 +118,7 @@ static int print_trace_stack(void *data, char *name)
  */
 static void print_trace_address(void *data, unsigned long addr, int reliable)
 {
-       printk_address(addr, reliable, (char *)data);
+       printk_address(addr, reliable);
 }
 
 static const struct stacktrace_ops print_trace_ops = {
index acd1c75..92b1ce1 100644 (file)
@@ -213,7 +213,7 @@ show_fault_oops(struct pt_regs *regs, unsigned long address)
                                     : "paging request",
                 address);
        pr_alert("PC:");
-       printk_address(regs->pc, 1, KERN_ALERT);
+       printk_address(regs->pc, 1);
 
        show_pte(NULL, address);
 }