Let's use the simpler `array_merge()` instead of `wp_parse_args()`

diff --git a/php/WP_CLI/CommandWithUpgrade.php b/php/WP_CLI/CommandWithUpgrade.php
index dac45fa..6568bd2 100644 (file)
--- a/php/WP_CLI/CommandWithUpgrade.php
+++ b/php/WP_CLI/CommandWithUpgrade.php
@@ -220,16 +220,16 @@ abstract class CommandWithUpgrade extends \WP_CLI_Command {
        }
 
        protected function _list( $_, $assoc_args ) {
-               $values = array(
+               $defaults = array(
                        'format' => 'table',
                        'fields' => $this->fields
                );
-               $values = wp_parse_args( $assoc_args, $values );
+               $assoc_args = array_merge( $defaults, $assoc_args );
 
                $all_items = $this->get_all_items();
                $items = $this->create_objects( $all_items );
 
-               \WP_CLI\Utils\format_items( $values['format'], $items, $values['fields'] );
+               \WP_CLI\Utils\format_items( $assoc_args['format'], $items, $assoc_args['fields'] );
        }
 
        /**

diff --git a/php/commands/post.php b/php/commands/post.php
index fb63554..22e0907 100644 (file)
--- a/php/commands/post.php
+++ b/php/commands/post.php
@@ -163,9 +163,10 @@ class Post_Command extends \WP_CLI\CommandWithDBObject {
         * @synopsis [--format=<format>] <ID>
         */
        public function get( $args, $assoc_args ) {
-               $assoc_args = wp_parse_args( $assoc_args, array(
+               $defaults = array(
                        'format' => 'table'
-               ) );
+               );
+               $assoc_args = array_merge( $defaults, $assoc_args );
 
                $post_id = $args[0];
                if ( !$post_id || !$post = get_post( $post_id ) )
@@ -216,9 +217,10 @@ class Post_Command extends \WP_CLI\CommandWithDBObject {
         * @synopsis <id>... [--force]
         */
        public function delete( $args, $assoc_args ) {
-               $assoc_args = wp_parse_args( $assoc_args, array(
+               $defaults = array(
                        'force' => false
-               ) );
+               );
+               $assoc_args = array_merge( $defaults, $assoc_args );
 
                parent::delete( $args, $assoc_args );
        }
@@ -265,12 +267,11 @@ class Post_Command extends \WP_CLI\CommandWithDBObject {
                        'posts_per_page'  => -1,
                        'post_status'     => 'any',
                );
-
-               $values = array(
+               $defaults = array(
                        'format' => 'table',
                        'fields' => $this->fields
                );
-               $values = wp_parse_args( $assoc_args, $values );
+               $assoc_args = array_merge( $defaults, $assoc_args );
 
                foreach ( $assoc_args as $key => $value ) {
                        if ( true === $value )
@@ -279,12 +280,12 @@ class Post_Command extends \WP_CLI\CommandWithDBObject {
                        $query_args[ $key ] = $value;
                }
 
-               if ( 'ids' == $values['format'] )
+               if ( 'ids' == $assoc_args['format'] )
                        $query_args['fields'] = 'ids';
 
                $query = new WP_Query( $query_args );
 
-               WP_CLI\Utils\format_items( $values['format'], $query->posts, $values['fields'] );
+               WP_CLI\Utils\format_items( $assoc_args['format'], $query->posts, $assoc_args['fields'] );
        }
 
        /**
@@ -328,7 +329,7 @@ class Post_Command extends \WP_CLI\CommandWithDBObject {
                        'post_date' => current_time( 'mysql' ),
                );
 
-               extract( wp_parse_args( $assoc_args, $defaults ), EXTR_SKIP );
+               extract( array_merge( $defaults, $assoc_args ), EXTR_SKIP );
 
                if ( !post_type_exists( $post_type ) ) {
                        WP_CLI::error( sprintf( "'%s' is not a registered post type.", $post_type ) );