OSDN Git Service

drm/i915/crtc: replace I915_STATE_WARN_ON() with I915_STATE_WARN()
authorJani Nikula <jani.nikula@intel.com>
Fri, 12 May 2023 11:04:42 +0000 (14:04 +0300)
committerJani Nikula <jani.nikula@intel.com>
Mon, 15 May 2023 09:13:46 +0000 (12:13 +0300)
Describe the assertion better.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230512110444.1448231-2-jani.nikula@intel.com
drivers/gpu/drm/i915/display/intel_crtc.c

index df7d05f..1e3f88d 100644 (file)
@@ -35,7 +35,9 @@
 
 static void assert_vblank_disabled(struct drm_crtc *crtc)
 {
-       if (I915_STATE_WARN_ON(drm_crtc_vblank_get(crtc) == 0))
+       if (I915_STATE_WARN(drm_crtc_vblank_get(crtc) == 0,
+                           "[CRTC:%d:%s] vblank assertion failure (expected off, current on)\n",
+                           crtc->base.id, crtc->name))
                drm_crtc_vblank_put(crtc);
 }