OSDN Git Service

mwifiex: utilize netif_tx_{wake,stop}_all_queues()
authorBrian Norris <briannorris@chromium.org>
Tue, 25 Jul 2017 01:13:27 +0000 (18:13 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 28 Jul 2017 14:47:50 +0000 (17:47 +0300)
We're open-coding these. Just use the helpers.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/marvell/mwifiex/init.c

index de974e8..e11919d 100644 (file)
@@ -337,17 +337,9 @@ void mwifiex_wake_up_net_dev_queue(struct net_device *netdev,
                                        struct mwifiex_adapter *adapter)
 {
        unsigned long dev_queue_flags;
-       unsigned int i;
 
        spin_lock_irqsave(&adapter->queue_lock, dev_queue_flags);
-
-       for (i = 0; i < netdev->num_tx_queues; i++) {
-               struct netdev_queue *txq = netdev_get_tx_queue(netdev, i);
-
-               if (netif_tx_queue_stopped(txq))
-                       netif_tx_wake_queue(txq);
-       }
-
+       netif_tx_wake_all_queues(netdev);
        spin_unlock_irqrestore(&adapter->queue_lock, dev_queue_flags);
 }
 
@@ -358,17 +350,9 @@ void mwifiex_stop_net_dev_queue(struct net_device *netdev,
                                        struct mwifiex_adapter *adapter)
 {
        unsigned long dev_queue_flags;
-       unsigned int i;
 
        spin_lock_irqsave(&adapter->queue_lock, dev_queue_flags);
-
-       for (i = 0; i < netdev->num_tx_queues; i++) {
-               struct netdev_queue *txq = netdev_get_tx_queue(netdev, i);
-
-               if (!netif_tx_queue_stopped(txq))
-                       netif_tx_stop_queue(txq);
-       }
-
+       netif_tx_stop_all_queues(netdev);
        spin_unlock_irqrestore(&adapter->queue_lock, dev_queue_flags);
 }