OSDN Git Service

drm/amdkfd Avoid destroy hqd when GPU is on reset
authorJack Zhang <Jack.Zhang1@amd.com>
Tue, 7 Apr 2020 05:44:51 +0000 (13:44 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 9 Apr 2020 14:43:15 +0000 (10:43 -0400)
This reverts commit 5161bba4311f in order to split it into two
different patches, and this will make it easier to understand.

[PATCH 1/2]
porting to gfx10 from
commit 1b0bfcff463f390c40 ("drm/amdgpu: Avoid destroy hqd when GPU is on reset")

Originally, MEC is touched
without GPU initialized first.

Signed-off-by: Jack Zhang <Jack.Zhang1@amd.com>
Reviewed-by: Monk Liu <monk.liu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

index bdc1f5a..691c897 100644 (file)
@@ -543,8 +543,8 @@ static int kgd_hqd_destroy(struct kgd_dev *kgd, void *mqd,
        uint32_t temp;
        struct v10_compute_mqd *m = get_mqd(mqd);
 
-       if (amdgpu_sriov_vf(adev) && adev->in_gpu_reset)
-               return 0;
+       if (adev->in_gpu_reset)
+               return -EIO;
 
 #if 0
        unsigned long flags;
index c2562d6..df841c2 100644 (file)
@@ -541,9 +541,6 @@ int kgd_gfx_v9_hqd_destroy(struct kgd_dev *kgd, void *mqd,
        uint32_t temp;
        struct v9_mqd *m = get_mqd(mqd);
 
-       if (amdgpu_sriov_vf(adev) && adev->in_gpu_reset)
-               return 0;
-
        if (adev->in_gpu_reset)
                return -EIO;
 
index f7c51fe..c387771 100644 (file)
@@ -3850,8 +3850,6 @@ static int amdgpu_device_reset_sriov(struct amdgpu_device *adev,
        if (r)
                return r;
 
-       amdgpu_amdkfd_pre_reset(adev);
-
        /* Resume IP prior to SMC */
        r = amdgpu_device_ip_reinit_early_sriov(adev);
        if (r)