OSDN Git Service

drm/msm: dsi: Return errors whan dt parsing fails
authorSean Paul <seanpaul@chromium.org>
Mon, 30 Jul 2018 15:26:54 +0000 (11:26 -0400)
committerRob Clark <robdclark@gmail.com>
Thu, 4 Oct 2018 00:24:49 +0000 (20:24 -0400)
If dt parsing fails, we should return an error instead of pretending
everything completed successfully.

Cc: Doug Anderson <dianders@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/dsi/dsi_host.c

index 96fb5f6..9c6c523 100644 (file)
@@ -1750,6 +1750,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host)
        if (ret) {
                dev_err(dev, "%s: invalid lane configuration %d\n",
                        __func__, ret);
+               ret = -EINVAL;
                goto err;
        }
 
@@ -1757,6 +1758,7 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host)
        device_node = of_graph_get_remote_node(np, 1, 0);
        if (!device_node) {
                dev_dbg(dev, "%s: no valid device\n", __func__);
+               ret = -ENODEV;
                goto err;
        }