OSDN Git Service

cifs: Silence uninitialized variable warning
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 19 Jun 2018 12:25:30 +0000 (15:25 +0300)
committerSteve French <stfrench@microsoft.com>
Tue, 7 Aug 2018 19:15:41 +0000 (14:15 -0500)
This is not really a runtime issue but Smatch complains that:

    fs/cifs/smb2ops.c:1740 smb2_query_symlink()
    error: uninitialized symbol 'resp_buftype'.

The warning is right that it can be uninitialized...  Also "err_buf"
would be NULL at this point and we're not supposed to pass NULLs to
free_rsp_buf() or it might trigger some extra output if we turn on
debugging.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2ops.c

index ea92a38..ae64cbe 100644 (file)
@@ -1700,7 +1700,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon,
                       &resp_buftype);
        if (!rc || !err_iov.iov_base) {
                rc = -ENOENT;
-               goto querty_exit;
+               goto free_path;
        }
 
        err_buf = err_iov.iov_base;
@@ -1741,6 +1741,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon,
 
  querty_exit:
        free_rsp_buf(resp_buftype, err_buf);
+ free_path:
        kfree(utf16_path);
        return rc;
 }