OSDN Git Service

[media] s2255drv: fix sparse warning
authorHans Verkuil <hans.verkuil@cisco.com>
Wed, 20 Aug 2014 22:25:34 +0000 (19:25 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Wed, 3 Sep 2014 12:54:16 +0000 (09:54 -0300)
drivers/media/usb/s2255/s2255drv.c:2248:20: warning: cast to restricted __le16

At the USB structs there are two different idProduct:
usb_device_id::idProduct - already on CPU endiannes
usb_device::descriptor.idProduct - with is LE16

In this specific case, the driver checks for the one at usb_device_id
struct, with already have CPU endianness. So, no conversion is required.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/usb/s2255/s2255drv.c

index 2c90186..ccc0009 100644 (file)
@@ -2245,7 +2245,7 @@ static int s2255_probe(struct usb_interface *interface,
        }
 
        atomic_set(&dev->num_channels, 0);
-       dev->pid = le16_to_cpu(id->idProduct);
+       dev->pid = id->idProduct;
        dev->fw_data = kzalloc(sizeof(struct s2255_fw), GFP_KERNEL);
        if (!dev->fw_data)
                goto errorFWDATA1;