OSDN Git Service

net: dsa: mv88e6xxx: Unlock on error in mv88e6xxx_port_bridge_join()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 7 Feb 2022 08:24:39 +0000 (11:24 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Feb 2022 12:35:10 +0000 (12:35 +0000)
Call mv88e6xxx_reg_unlock(chip) before returning on this error path.

Fixes: 7af4a361a62f ("net: dsa: mv88e6xxx: Improve isolation of standalone ports")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/chip.c

index 192a768..c54649c 100644 (file)
@@ -2602,7 +2602,7 @@ static int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port,
 
        err = mv88e6xxx_port_set_map_da(chip, port, true);
        if (err)
-               return err;
+               goto unlock;
 
        err = mv88e6xxx_port_commit_pvid(chip, port);
        if (err)