OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6efb943
)
platform/x86: ideapad-laptop: fix a NULL pointer dereference
author
Qiu Wenbo
<qiuwenbo@kylinos.com.cn>
Wed, 28 Apr 2021 05:06:36 +0000
(13:06 +0800)
committer
Hans de Goede
<hdegoede@redhat.com>
Tue, 11 May 2021 11:36:10 +0000
(13:36 +0200)
The third parameter of dytc_cql_command should not be NULL since it will
be dereferenced immediately.
Fixes:
ff36b0d953dc4
("platform/x86: ideapad-laptop: rework and create new ACPI helpers")
Signed-off-by: Qiu Wenbo <qiuwenbo@kylinos.com.cn>
Acked-by: Ike Panhc <ike.pan@canonical.com>
Link:
https://lore.kernel.org/r/20210428050636.8003-1-qiuwenbo@kylinos.com.cn
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/ideapad-laptop.c
patch
|
blob
|
history
diff --git
a/drivers/platform/x86/ideapad-laptop.c
b/drivers/platform/x86/ideapad-laptop.c
index
6cb5ad4
..
8f87115
100644
(file)
--- a/
drivers/platform/x86/ideapad-laptop.c
+++ b/
drivers/platform/x86/ideapad-laptop.c
@@
-809,6
+809,7
@@
static int dytc_profile_set(struct platform_profile_handler *pprof,
{
struct ideapad_dytc_priv *dytc = container_of(pprof, struct ideapad_dytc_priv, pprof);
struct ideapad_private *priv = dytc->priv;
+ unsigned long output;
int err;
err = mutex_lock_interruptible(&dytc->mutex);
@@
-829,7
+830,7
@@
static int dytc_profile_set(struct platform_profile_handler *pprof,
/* Determine if we are in CQL mode. This alters the commands we do */
err = dytc_cql_command(priv, DYTC_SET_COMMAND(DYTC_FUNCTION_MMC, perfmode, 1),
-
NULL
);
+
&output
);
if (err)
goto unlock;
}