OSDN Git Service

fork: Rename bad_fork_cleanup_threadgroup_lock to bad_fork_cleanup_delayacct
authorEric W. Biederman <ebiederm@xmission.com>
Mon, 20 Dec 2021 16:42:18 +0000 (10:42 -0600)
committerEric W. Biederman <ebiederm@xmission.com>
Mon, 20 Dec 2021 16:51:00 +0000 (10:51 -0600)
I just fixed a bug in copy_process when using the label
bad_fork_cleanup_threadgroup_lock.  While fixing the bug I looked
closer at the label and realized it has been misnamed since
568ac888215c ("cgroup: reduce read locked section of
cgroup_threadgroup_rwsem during fork").

Fix the name so that fork is easier to understand.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
kernel/fork.c

index 23ad629..0816be1 100644 (file)
@@ -2120,14 +2120,14 @@ static __latent_entropy struct task_struct *copy_process(
        cgroup_fork(p);
        if (p->flags & PF_KTHREAD) {
                if (!set_kthread_struct(p))
-                       goto bad_fork_cleanup_threadgroup_lock;
+                       goto bad_fork_cleanup_delayacct;
        }
 #ifdef CONFIG_NUMA
        p->mempolicy = mpol_dup(p->mempolicy);
        if (IS_ERR(p->mempolicy)) {
                retval = PTR_ERR(p->mempolicy);
                p->mempolicy = NULL;
-               goto bad_fork_cleanup_threadgroup_lock;
+               goto bad_fork_cleanup_delayacct;
        }
 #endif
 #ifdef CONFIG_CPUSETS
@@ -2465,7 +2465,7 @@ bad_fork_cleanup_policy:
 #ifdef CONFIG_NUMA
        mpol_put(p->mempolicy);
 #endif
-bad_fork_cleanup_threadgroup_lock:
+bad_fork_cleanup_delayacct:
        delayacct_tsk_free(p);
 bad_fork_cleanup_count:
        dec_rlimit_ucounts(task_ucounts(p), UCOUNT_RLIMIT_NPROC, 1);