From: Cao jin Date: Thu, 21 Jul 2016 10:33:32 +0000 (+0800) Subject: util: drop inet_nonblocking_connect() X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=00432b69538559285ca55677c1002cad556aea50;p=qmiga%2Fqemu.git util: drop inet_nonblocking_connect() It is never used; all nonblocking connect now goes through socket_connect(), which calls inet_connect_addr(). Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Signed-off-by: Cao jin Message-Id: <1469097213-26441-2-git-send-email-caoj.fnst@cn.fujitsu.com> Signed-off-by: Paolo Bonzini --- diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h index 5fe01fbc6c..2cbe6432cd 100644 --- a/include/qemu/sockets.h +++ b/include/qemu/sockets.h @@ -36,9 +36,6 @@ InetSocketAddress *inet_parse(const char *str, Error **errp); int inet_listen(const char *str, char *ostr, int olen, int socktype, int port_offset, Error **errp); int inet_connect(const char *str, Error **errp); -int inet_nonblocking_connect(const char *str, - NonBlockingConnectHandler *callback, - void *opaque, Error **errp); NetworkAddressFamily inet_netfamily(int family); diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 777af49d53..2e0570b2b7 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -674,36 +674,6 @@ int inet_connect(const char *str, Error **errp) return sock; } -/** - * Create a non-blocking socket and connect it to an address. - * Calls the callback function with fd in case of success or -1 in case of - * error. - * - * @str: address string - * @callback: callback function that is called when connect completes, - * cannot be NULL. - * @opaque: opaque for callback function - * @errp: set in case of an error - * - * Returns: -1 on immediate error, file descriptor on success. - **/ -int inet_nonblocking_connect(const char *str, - NonBlockingConnectHandler *callback, - void *opaque, Error **errp) -{ - int sock = -1; - InetSocketAddress *addr; - - g_assert(callback != NULL); - - addr = inet_parse(str, errp); - if (addr != NULL) { - sock = inet_connect_saddr(addr, errp, callback, opaque); - qapi_free_InetSocketAddress(addr); - } - return sock; -} - #ifndef _WIN32 static int unix_listen_saddr(UnixSocketAddress *saddr,