From: Vladimir Marko <vmarko@google.com>
Date: Fri, 2 Jan 2015 17:00:44 +0000 (+0000)
Subject: Fix BitVector::IndexIterator::operator*() to return uint32_t.
X-Git-Tag: android-x86-7.1-r1~889^2~2146^2
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=040719630f33019693b5c4d9b573311b2f935c39;p=android-x86%2Fart.git

Fix BitVector::IndexIterator::operator*() to return uint32_t.

Change-Id: I3cfc028b1c3744ec85ea00eadcbccfdde6fd51d3
---

diff --git a/runtime/base/bit_vector-inl.h b/runtime/base/bit_vector-inl.h
index dc13dd5b9..39b19e548 100644
--- a/runtime/base/bit_vector-inl.h
+++ b/runtime/base/bit_vector-inl.h
@@ -29,7 +29,7 @@ inline bool BitVector::IndexIterator::operator==(const IndexIterator& other) con
   return bit_index_ == other.bit_index_;
 }
 
-inline int BitVector::IndexIterator::operator*() const {
+inline uint32_t BitVector::IndexIterator::operator*() const {
   DCHECK_LT(bit_index_, BitSize());
   return bit_index_;
 }
diff --git a/runtime/base/bit_vector.h b/runtime/base/bit_vector.h
index 1e28a27e9..557a2ec11 100644
--- a/runtime/base/bit_vector.h
+++ b/runtime/base/bit_vector.h
@@ -52,7 +52,7 @@ class BitVector {
       return !(*this == other);
     }
 
-    int operator*() const;
+    uint32_t operator*() const;
 
     IndexIterator& operator++();
 
diff --git a/runtime/base/bit_vector_test.cc b/runtime/base/bit_vector_test.cc
index 31fd0e7f3..fe3313d12 100644
--- a/runtime/base/bit_vector_test.cc
+++ b/runtime/base/bit_vector_test.cc
@@ -57,10 +57,10 @@ TEST(BitVector, Test) {
 
   BitVector::IndexIterator iterator = bv.Indexes().begin();
   EXPECT_TRUE(iterator != bv.Indexes().end());
-  EXPECT_EQ(0, *iterator);
+  EXPECT_EQ(0u, *iterator);
   ++iterator;
   EXPECT_TRUE(iterator != bv.Indexes().end());
-  EXPECT_EQ(static_cast<int>(kBits - 1), *iterator);
+  EXPECT_EQ(kBits - 1u, *iterator);
   ++iterator;
   EXPECT_TRUE(iterator == bv.Indexes().end());
 }