From: Ivailo Monev Date: Fri, 6 Nov 2020 14:47:39 +0000 (+0200) Subject: avoid temporary in QFile::readLineData() X-Git-Tag: 4.12.0~3417 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=04d1139533c612daebb56a2ab636d270149e54aa;p=kde%2FKatie.git avoid temporary in QFile::readLineData() Signed-off-by: Ivailo Monev --- diff --git a/src/core/io/qfile.cpp b/src/core/io/qfile.cpp index 45f14d3df..5beeb8ab1 100644 --- a/src/core/io/qfile.cpp +++ b/src/core/io/qfile.cpp @@ -1311,16 +1311,12 @@ qint64 QFile::readLineData(char *data, qint64 maxlen) if (!d->ensureFlushed()) return -1; - qint64 read; if (d->fileEngine->supportsExtension(QAbstractFileEngine::FastReadLineExtension)) { - read = d->fileEngine->readLine(data, maxlen); - } else { - // Fall back to QIODevice's readLine implementation if the engine - // cannot do it faster. - read = QIODevice::readLineData(data, maxlen); + return d->fileEngine->readLine(data, maxlen); } - - return read; + // Fall back to QIODevice's readLine implementation if the engine + // cannot do it faster. + return QIODevice::readLineData(data, maxlen); } /*!