From: Christophe JAILLET Date: Sun, 24 Jan 2021 07:39:55 +0000 (+0100) Subject: mtd: rawnand: intel: Fix an error handling path in 'ebu_dma_start()' X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=073abfa7ea9a5b0537d6f92b42baedaf82a04c53;p=uclinux-h8%2Flinux.git mtd: rawnand: intel: Fix an error handling path in 'ebu_dma_start()' If 'dmaengine_prep_slave_single()' fails, we must undo a previous 'dma_map_single()' call, as already done in all the other error handling paths of this function. Fixes: 0b1039f016e8 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Christophe JAILLET Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20210124073955.728797-1-christophe.jaillet@wanadoo.fr --- diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index fdb112e8a90d..4c08e9f9fbbe 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -318,8 +318,10 @@ static int ebu_dma_start(struct ebu_nand_controller *ebu_host, u32 dir, } tx = dmaengine_prep_slave_single(chan, buf_dma, len, dir, flags); - if (!tx) - return -ENXIO; + if (!tx) { + ret = -ENXIO; + goto err_unmap; + } tx->callback = callback; tx->callback_param = ebu_host;