From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Mon, 26 Jan 2015 15:48:33 +0000 (+0100)
Subject: commit: reword --author error message
X-Git-Tag: v2.3.1~4^2
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=1044b1f6a1a56ae723fd19cddd769380dc775f48;p=git-core%2Fgit.git

commit: reword --author error message

If an --author argument is specified but does not contain a '>' then git tries
to find the argument within the existing authors; and gives the error
message "No existing author found with '%s'" if there is no match.

This is confusing for users who try to specify a valid complete author
name.

Rename the error message to make it clearer that the failure has two
reasons in this case.

(This codepath is touched only when we know already that the argument
cannot be a completely wellformed author ident.)

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/commit.c b/builtin/commit.c
index 39cf8976e..304c0bf45 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -999,7 +999,7 @@ static const char *find_author_by_nickname(const char *name)
 		clear_mailmap(&mailmap);
 		return strbuf_detach(&buf, NULL);
 	}
-	die(_("No existing author found with '%s'"), name);
+	die(_("--author '%s' is not 'Name <email>' and matches no existing author"), name);
 }