From: Gustavo A. R. Silva Date: Wed, 17 Jun 2020 17:56:47 +0000 (-0500) Subject: fbdev/fb.h: Use struct_size() helper in kzalloc() X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=17d8dcf5330a97f6e5ae01d336eb1641782043f9;p=uclinux-h8%2Flinux.git fbdev/fb.h: Use struct_size() helper in kzalloc() Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Bartlomiej Zolnierkiewicz Link: https://patchwork.freedesktop.org/patch/msgid/20200617175647.GA26370@embeddedor --- diff --git a/include/linux/fb.h b/include/linux/fb.h index 3b4b2f0c6994..2b530e6d86e4 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -506,8 +506,9 @@ struct fb_info { }; static inline struct apertures_struct *alloc_apertures(unsigned int max_num) { - struct apertures_struct *a = kzalloc(sizeof(struct apertures_struct) - + max_num * sizeof(struct aperture), GFP_KERNEL); + struct apertures_struct *a; + + a = kzalloc(struct_size(a, ranges, max_num), GFP_KERNEL); if (!a) return NULL; a->count = max_num;