From: Christian Gmeiner Date: Fri, 9 Jun 2017 10:27:34 +0000 (+0200) Subject: etnaviv: submit full struct drm_etnaviv_gem_submit X-Git-Tag: android-x86-7.1-r1~30 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=2393acd14487db0b7bedcf5af7b3710066809cbc;p=android-x86%2Fexternal-libdrm.git etnaviv: submit full struct drm_etnaviv_gem_submit It is safe to submit the full struct even on older kernels as such kernels do not process the full struct. Without this change it becomes quite challenging to extned the submit struct. Freedreno has no special treatment too. See git commits - freedreno: sync uapi header - freedreno: add fence fd support Signed-off-by: Christian Gmeiner Reviewed-by: Philipp Zabel Tested-by: Philipp Zabel --- diff --git a/etnaviv/etnaviv_cmd_stream.c b/etnaviv/etnaviv_cmd_stream.c index 3c7b0ed6..8d0e8135 100644 --- a/etnaviv/etnaviv_cmd_stream.c +++ b/etnaviv/etnaviv_cmd_stream.c @@ -203,14 +203,8 @@ static void flush(struct etna_cmd_stream *stream, int in_fence_fd, if (out_fence_fd) req.flags |= ETNA_SUBMIT_FENCE_FD_OUT; - /* - * Pass the complete submit structure only if flags are set. Otherwise, - * only pass the fields up to, but not including the flags field for - * backwards compatiblity with older kernels. - */ ret = drmCommandWriteRead(gpu->dev->fd, DRM_ETNAVIV_GEM_SUBMIT, - &req, req.flags ? sizeof(req) : - offsetof(struct drm_etnaviv_gem_submit, flags)); + &req, sizeof(req)); if (ret) ERROR_MSG("submit failed: %d (%s)", ret, strerror(errno));