From: Janis Danisevskis <jdanis@google.com>
Date: Wed, 5 Dec 2018 00:52:58 +0000 (-0800)
Subject: Fix inverted error code.
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=25f58c7312;p=android-x86%2Fsystem-hardware-interfaces.git

Fix inverted error code.

During the Multithreaded keystore refactor the error code returned by
getKeyCharacteristics was mistakenly inverted.

Test: yes please!
Bug: 120182820
Bug: 111443219
Change-Id: I5f5c07f30e0ee264ce75a5ffd2986186b9d66ce3
---

diff --git a/wifi/keystore/1.0/default/keystore.cpp b/wifi/keystore/1.0/default/keystore.cpp
index c1594e8..fef8400 100644
--- a/wifi/keystore/1.0/default/keystore.cpp
+++ b/wifi/keystore/1.0/default/keystore.cpp
@@ -165,7 +165,7 @@ Return<void> Keystore::sign(const hidl_string& keyId, const hidl_vec<uint8_t>& d
 
     auto [km_response, characteristics] = kc_future.get();
 
-    if (KSReturn(km_response.response_code()).isOk()) {
+    if (!KSReturn(km_response.response_code()).isOk()) {
         LOG(ERROR) << AT << "getKeyCharacteristics failed: " << km_response.response_code();
         _hidl_cb(KeystoreStatusCode::ERROR_UNKNOWN, {});
         return Void();