From: Aurelien Jacobs <aurel@gnuage.org>
Date: Thu, 26 Feb 2009 13:11:18 +0000 (+0000)
Subject: return -1 for errors in ff_mov_iso639_to_lang() to allow for error checking
X-Git-Tag: v0.5~128
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=2904fd398f26f0a2db99dcec54cd009826344c61;p=coroid%2Flibav_saccubus.git

return -1 for errors in ff_mov_iso639_to_lang() to allow for error checking

Originally committed as revision 17611 to svn://svn.ffmpeg.org/ffmpeg/trunk
---

diff --git a/libavformat/isom.c b/libavformat/isom.c
index 39c58c64d..b78d65e8f 100644
--- a/libavformat/isom.c
+++ b/libavformat/isom.c
@@ -257,7 +257,7 @@ int ff_mov_iso639_to_lang(const char *lang, int mp4)
     }
     /* XXX:can we do that in mov too? */
     if (!mp4)
-        return 0;
+        return -1;
     /* handle undefined as such */
     if (lang[0] == '\0')
         lang = "und";
@@ -265,9 +265,9 @@ int ff_mov_iso639_to_lang(const char *lang, int mp4)
     for (i = 0; i < 3; i++) {
         unsigned char c = (unsigned char)lang[i];
         if (c < 0x60)
-            return 0;
+            return -1;
         if (c > 0x60 + 0x1f)
-            return 0;
+            return -1;
         code <<= 5;
         code |= (c - 0x60);
     }
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index ad2785030..0a37eb4fc 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -1651,6 +1651,8 @@ static int mov_write_header(AVFormatContext *s)
 
         track->enc = st->codec;
         track->language = ff_mov_iso639_to_lang(lang?lang->value:"und", mov->mode!=MODE_MOV);
+        if (track->language < 0)
+            track->language = 0;
         track->mode = mov->mode;
         track->tag = mov_find_codec_tag(s, track);
         if (!track->tag) {