From: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
Date: Wed, 10 Dec 2008 15:12:57 +0000 (+0000)
Subject: Fix off-by-one bug limiting VNC passwords to 7 chars (Chris Webb)
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=2a7e8dda090af586f3d0b3d157054a9e18776a52;p=qmiga%2Fqemu.git

Fix off-by-one bug limiting VNC passwords to 7 chars (Chris Webb)

monitor_readline expects buf_size to include the terminating \0, but
do_change_vnc in monitor.c calls it as though it doesn't. The other site
where monitor_readline reads a password (in vl.c) passes the buffer
length
correctly.

Signed-off-by: Chris Webb <chris@arachsys.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>



git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5966 c046a42c-6fe2-441c-8c8c-71466251a162
---

diff --git a/monitor.c b/monitor.c
index f142a879f4..bec9211b21 100644
--- a/monitor.c
+++ b/monitor.c
@@ -434,8 +434,7 @@ static void do_change_vnc(const char *target)
     if (strcmp(target, "passwd") == 0 ||
 	strcmp(target, "password") == 0) {
 	char password[9];
-	monitor_readline("Password: ", 1, password, sizeof(password)-1);
-	password[sizeof(password)-1] = '\0';
+	monitor_readline("Password: ", 1, password, sizeof(password));
 	if (vnc_display_password(NULL, password) < 0)
 	    term_printf("could not set VNC server password\n");
     } else {