From: Jani Nikula Date: Thu, 28 Sep 2017 08:21:59 +0000 (+0300) Subject: drm/i915/bios: don't initialize fields based on vbt version X-Git-Tag: android-x86-8.1-r1~365^2~46^2~1409 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=2d936f1cf78fe84c05642545abe052488e7adad4;p=android-x86%2Fkernel.git drm/i915/bios: don't initialize fields based on vbt version In theory, these might clobber information for older VBT versions. We might have to store the BDB version for later parsing, but currently all code accessing these fields will only use them on newer platforms with new enough BDB versions. Reviewed-by: Ville Syrjälä Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/0232d9cb258e8f83c4180cdb8aad1459a312ec2a.1506586821.git.jani.nikula@intel.com --- diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index 22924612c680..c91cdf131465 100644 --- a/drivers/gpu/drm/i915/intel_bios.c +++ b/drivers/gpu/drm/i915/intel_bios.c @@ -1347,19 +1347,6 @@ parse_device_mapping(struct drm_i915_private *dev_priv, */ memcpy(child_dev_ptr, child, min_t(size_t, defs->child_dev_size, sizeof(*child))); - - /* - * copied full block, now init values when they are not - * available in current version - */ - if (bdb->version < 196) { - /* Set default values for bits added from v196 */ - child_dev_ptr->iboost = 0; - child_dev_ptr->hpd_invert = 0; - } - - if (bdb->version < 192) - child_dev_ptr->lspcon = 0; } return; }