From: Sanjoy Das Date: Fri, 22 Jul 2016 00:40:56 +0000 (+0000) Subject: [IRCE] Add an option to skip profitability checks X-Git-Tag: android-x86-7.1-r4~29848 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=304682fc9c599ce2bf7661f051ad7d10ea1065be;p=android-x86%2Fexternal-llvm.git [IRCE] Add an option to skip profitability checks If `-irce-skip-profitability-checks` is passed in, IRCE will kick in in all cases where it is legal for it to kick in. This flag is intended to help diagnose and analyse performance issues. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@276372 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp b/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp index ec7f09a2d59..52e94fa0766 100644 --- a/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp +++ b/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp @@ -82,6 +82,9 @@ static cl::opt PrintRangeChecks("irce-print-range-checks", cl::Hidden, static cl::opt MaxExitProbReciprocal("irce-max-exit-prob-reciprocal", cl::Hidden, cl::init(10)); +static cl::opt SkipProfitabilityChecks("irce-skip-profitability-checks", + cl::Hidden, cl::init(false)); + #define DEBUG_TYPE "irce" namespace { @@ -392,7 +395,8 @@ void InductiveRangeCheck::extractRangeChecksFromBranch( BranchProbability LikelyTaken(15, 16); - if (BPI.getEdgeProbability(BI->getParent(), (unsigned)0) < LikelyTaken) + if (!SkipProfitabilityChecks && + BPI.getEdgeProbability(BI->getParent(), (unsigned)0) < LikelyTaken) return; SmallPtrSet Visited; @@ -648,7 +652,8 @@ LoopStructure::parseLoopStructure(ScalarEvolution &SE, BranchProbabilityInfo &BP BranchProbability ExitProbability = BPI.getEdgeProbability(LatchBr->getParent(), LatchBrExitIdx); - if (ExitProbability > BranchProbability(1, MaxExitProbReciprocal)) { + if (!SkipProfitabilityChecks && + ExitProbability > BranchProbability(1, MaxExitProbReciprocal)) { FailureReason = "short running loop, not profitable"; return None; } diff --git a/test/Transforms/IRCE/skip-profitability-checks.ll b/test/Transforms/IRCE/skip-profitability-checks.ll new file mode 100644 index 00000000000..f12898955b4 --- /dev/null +++ b/test/Transforms/IRCE/skip-profitability-checks.ll @@ -0,0 +1,31 @@ +; RUN: opt -irce-skip-profitability-checks -S -irce < %s | FileCheck %s + +define void @single_access_no_preloop_no_offset(i32 *%arr, i32 *%a_len_ptr, i32 %n) { +; CHECK-LABEL: @single_access_no_preloop_no_offset( +; CHECK: main.exit.selector: + entry: + %len = load i32, i32* %a_len_ptr, !range !0 + %first.itr.check = icmp sgt i32 %n, 0 + br i1 %first.itr.check, label %loop, label %exit + + loop: + %idx = phi i32 [ 0, %entry ] , [ %idx.next, %in.bounds ] + %idx.next = add i32 %idx, 1 + %abc = icmp slt i32 %idx, %len + br i1 %abc, label %in.bounds, label %out.of.bounds, !prof !1 + + in.bounds: + %addr = getelementptr i32, i32* %arr, i32 %idx + store i32 0, i32* %addr + %next = icmp slt i32 %idx.next, %n + br i1 %next, label %loop, label %exit + + out.of.bounds: + ret void + + exit: + ret void +} + +!0 = !{i32 0, i32 2147483647} +!1 = !{!"branch_weights", i32 1, i32 64}