From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Tue, 28 Aug 2012 21:38:58 +0000 (-0300)
Subject: [media] uvcvideo: Return -EACCES when trying to access a read/write-only control
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=30ecb936cbcd83e3735625ac63e1b4466546f5fe;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git

[media] uvcvideo: Return -EACCES when trying to access a read/write-only control

The proper return code according to the V4L2 specification is -EACCES,
not -EINVAL.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
index 7879d306f1fc..3e0b66efc9ba 100644
--- a/drivers/media/usb/uvc/uvc_ctrl.c
+++ b/drivers/media/usb/uvc/uvc_ctrl.c
@@ -927,7 +927,7 @@ static int __uvc_ctrl_get(struct uvc_video_chain *chain,
 	int ret;
 
 	if ((ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR) == 0)
-		return -EINVAL;
+		return -EACCES;
 
 	if (!ctrl->loaded) {
 		ret = uvc_query_ctrl(chain->dev, UVC_GET_CUR, ctrl->entity->id,
@@ -1435,7 +1435,7 @@ int uvc_ctrl_set(struct uvc_video_chain *chain,
 	if (ctrl == NULL)
 		return -ENOENT;
 	if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR))
-		return -EINVAL;
+		return -EACCES;
 
 	/* Clamp out of range values. */
 	switch (mapping->v4l2_type) {