From: Dan Carpenter Date: Thu, 22 Oct 2015 19:52:59 +0000 (+0300) Subject: ACPI / CPPC: signedness bug in register_pcc_channel() X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=32c0b2f606a4b71fc7b7cfa479cf47648854d9d9;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git ACPI / CPPC: signedness bug in register_pcc_channel() The "pcc_subspace_idx" is -1 if it hasn't been initialized yet. We need it to be signed. Fixes: 337aadff8e45 (ACPI: Introduce CPU performance controls using CPPC) Signed-off-by: Dan Carpenter Acked-by: Ashwin Chaugule Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 0bbf84bdcdc4..2ed55161bca5 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -302,7 +302,7 @@ err_ret: } EXPORT_SYMBOL_GPL(acpi_get_psd_map); -static int register_pcc_channel(unsigned pcc_subspace_idx) +static int register_pcc_channel(int pcc_subspace_idx) { struct acpi_pcct_subspace *cppc_ss; unsigned int len;