From: Colin Ian King Date: Mon, 4 Dec 2017 17:08:15 +0000 (+0000) Subject: pinctrl: intel: ensure error return ret is initialized X-Git-Tag: v4.16-rc1~90^2~68 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=33b6cb58cbb6c872ebf874d8017c27aaa2130928;p=uclinux-h8%2Flinux.git pinctrl: intel: ensure error return ret is initialized In the (unlikely) event that community->ngpps is zero, or if every gpp->gpio_base is less than zero, then an ininitialized value in ret is returned by function intel_gpio_add_pin_ranges. Fix this by ensuring ret is initialized to zero. It's a moot point, but I think it is worthwhile ensuring this corner case is fixed. Detected by CoverityScan, CID#1462415 ("Uninitialized scalar variable") Fixes: a60eac3239f0 ("pinctrl: intel: Allow custom GPIO base for pad groups") Signed-off-by: Colin Ian King Acked-by: Mika Westerberg Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 359800fcb951..96e73e30204e 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1083,7 +1083,7 @@ static struct irq_chip intel_gpio_irqchip = { static int intel_gpio_add_pin_ranges(struct intel_pinctrl *pctrl, const struct intel_community *community) { - int ret, i; + int ret = 0, i; for (i = 0; i < community->ngpps; i++) { const struct intel_padgroup *gpp = &community->gpps[i];