From: Michael Niedermayer Date: Wed, 16 Jul 2008 02:10:21 +0000 (+0000) Subject: The funny memcpyin svq3 generally has src & dst overlapping, so it X-Git-Tag: v0.5~3654 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=38844c0b42c31d1b248ae90c385fea6fd85c026b;p=coroid%2Flibav_saccubus.git The funny memcpyin svq3 generally has src & dst overlapping, so it should at least be a memmove(). Originally committed as revision 14254 to svn://svn.ffmpeg.org/ffmpeg/trunk --- diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 67fa3172b..a5868e1ce 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -704,7 +704,7 @@ static int svq3_decode_slice_header (H264Context *h) { skip_bits(&s->gb, 8); if (length > 0) { - memcpy ((uint8_t *) &s->gb.buffer[get_bits_count(&s->gb) >> 3], + memmove ((uint8_t *) &s->gb.buffer[get_bits_count(&s->gb) >> 3], &s->gb.buffer[s->gb.size_in_bits >> 3], (length - 1)); } }