From: Elliott Hughes <enh@google.com>
Date: Tue, 23 Apr 2013 18:35:17 +0000 (-0700)
Subject: Remove spammy logging from 8470684 investigation.
X-Git-Tag: android-x86-4.4-r1~28^2~9^2~42^2
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=3a9dbd30eb1598c737af7ef6110d46767d6e0336;p=android-x86%2Fdalvik.git

Remove spammy logging from 8470684 investigation.

This has been tracked down to a kernel bug, so we no longer need
the extra diagnostics.

Bug: 8470684
Change-Id: Ib170d1f7b94488ed4acc763f8dddc44c81807aed
---

diff --git a/vm/Thread.cpp b/vm/Thread.cpp
index cfc43486d..7c8395e3f 100644
--- a/vm/Thread.cpp
+++ b/vm/Thread.cpp
@@ -1309,52 +1309,12 @@ bool dvmCreateInterpThread(Object* threadObj, int reqStackSize)
          * so use OutOfMemoryError.
          */
 
-#if HAVE_ANDROID_OS
-        struct mallinfo malloc_info;
-        malloc_info = mallinfo();
-        ALOGE("Native heap free: %zd of %zd bytes", malloc_info.fordblks, malloc_info.uordblks);
-#endif
-
-        size_t thread_count = 0;
-        DIR* d = opendir("/proc/self/task");
-        if (d != NULL) {
-            dirent* entry = NULL;
-            while ((entry = readdir(d)) != NULL) {
-                char* end;
-                strtol(entry->d_name, &end, 10);
-                if (!*end) {
-                    ++thread_count;
-                }
-            }
-            closedir(d);
-        }
-
-        ALOGE("pthread_create (%d threads) failed: %s", thread_count, strerror(cc));
-
-        // Super-verbose output to help track down http://b/8470684.
-        size_t map_count = 0;
-        FILE* fp = fopen("/proc/self/maps", "r");
-        if (fp != NULL) {
-            char buf[1024];
-            while (fgets(buf, sizeof(buf), fp) != NULL) {
-                ALOGE("/proc/self/maps: %s", buf);
-                ++map_count;
-            }
-            fclose(fp);
-        }
-
         dvmSetFieldObject(threadObj, gDvm.offJavaLangThread_vmThread, NULL);
 
+        ALOGE("pthread_create (stack size %d bytes) failed: %s", stackSize, strerror(cc));
         dvmThrowExceptionFmt(gDvm.exOutOfMemoryError,
-                             "pthread_create (%d threads, %d map entries, "
-#if HAVE_ANDROID_OS
-                             "%zd free of %zd native heap bytes"
-#endif
-                             ") failed: %s", thread_count, map_count,
-#if HAVE_ANDROID_OS
-                             malloc_info.fordblks, malloc_info.uordblks,
-#endif
-                             strerror(cc));
+                             "pthread_create (stack size %d bytes) failed: %s",
+                             stackSize, strerror(cc));
         goto fail;
     }