From: cosmohsieh <cosmohsieh@google.com>
Date: Wed, 20 Mar 2019 06:48:32 +0000 (+0800)
Subject: [Network Connection] Don't dismiss dialog when touching outside of
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=3babe9e908acd30181c28ebc1a323895100a9287;p=android-x86%2Fpackages-apps-Settings.git

[Network Connection] Don't dismiss dialog when touching outside of
dialog

To Improve user experience, prevent dialog dismissing from touching outside
of the dialog

Bug: 128877712
Test: atest NetworkRequestDialogFragment
Change-Id: Idfa90c3647f5cf766aaa63fdb8a829fec5db5934
---

diff --git a/src/com/android/settings/wifi/NetworkRequestDialogFragment.java b/src/com/android/settings/wifi/NetworkRequestDialogFragment.java
index 09360e427d..bfd8d1cc6b 100644
--- a/src/com/android/settings/wifi/NetworkRequestDialogFragment.java
+++ b/src/com/android/settings/wifi/NetworkRequestDialogFragment.java
@@ -138,6 +138,10 @@ public class NetworkRequestDialogFragment extends InstrumentedDialogFragment imp
                 .setOnItemClickListener(
                         (parent, view, position, id) -> this.onClick(dialog, position));
 
+        // Don't dismiss dialog when touching outside. User report it is easy to touch outside.
+        // This causes dialog to close. Which is concerned as a bad UX (b/128877712).
+        dialog.setCanceledOnTouchOutside(false);
+
         dialog.setOnShowListener((dialogInterface) -> {
             // Replace NeutralButton onClickListener to avoid closing dialog
             final Button neutralBtn = dialog.getButton(AlertDialog.BUTTON_NEUTRAL);