From: Gustavo A. R. Silva Date: Fri, 24 Jul 2020 16:50:27 +0000 (-0500) Subject: crypto: sa2ul - Fix inconsistent IS_ERR and PTR_ERR X-Git-Tag: v5.9-rc1~33^2~1 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=3cbfe80737c18ac6e635421ab676716a393d3074;p=tomoyo%2Ftomoyo-test1.git crypto: sa2ul - Fix inconsistent IS_ERR and PTR_ERR Fix inconsistent IS_ERR and PTR_ERR in sa_dma_init(). The proper pointer to be passed as argument to PTR_ERR() is dd->dma_tx. This bug was detected with the help of Coccinelle. Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index ebcdffcdb686..5bc099052bd2 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -2259,7 +2259,7 @@ static int sa_dma_init(struct sa_crypto_data *dd) dd->dma_tx = dma_request_chan(dd->dev, "tx"); if (IS_ERR(dd->dma_tx)) { - if (PTR_ERR(dd->dma_rx1) != -EPROBE_DEFER) + if (PTR_ERR(dd->dma_tx) != -EPROBE_DEFER) dev_err(dd->dev, "Unable to request tx DMA channel\n"); ret = PTR_ERR(dd->dma_tx); goto err_dma_tx;