From: Kees Cook <keescook@chromium.org>
Date: Tue, 10 Jun 2014 17:51:08 +0000 (-0700)
Subject: bsr: avoid format string leaking into device name
X-Git-Tag: v3.17-rc1~125^2~43
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=4171ee9e3cd27718ce21f19aa00ea892655b28af;p=uclinux-h8%2Flinux.git

bsr: avoid format string leaking into device name

This makes sure a format string cannot accidentally leak into a device name.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
index 8fedbc250414..a6cef548e01e 100644
--- a/drivers/char/bsr.c
+++ b/drivers/char/bsr.c
@@ -259,7 +259,7 @@ static int bsr_add_node(struct device_node *bn)
 		}
 
 		cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,
-						cur, cur->bsr_name);
+						cur, "%s", cur->bsr_name);
 		if (IS_ERR(cur->bsr_device)) {
 			printk(KERN_ERR "device_create failed for %s\n",
 			       cur->bsr_name);