From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 3 Nov 2015 22:02:44 +0000 (+0300)
Subject: bus: sunxi-rsb: unlock on error in sunxi_rsb_read()
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=43675ffafd3c3373f82691f539df3dc7403877fe;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git

bus: sunxi-rsb: unlock on error in sunxi_rsb_read()

Don't forget to unlock before returning an error code.

Fixes: d787dcdb9c8f ('bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---

diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c
index 846bc29c157d..0cfcb39c53f4 100644
--- a/drivers/bus/sunxi-rsb.c
+++ b/drivers/bus/sunxi-rsb.c
@@ -342,13 +342,13 @@ static int sunxi_rsb_read(struct sunxi_rsb *rsb, u8 rtaddr, u8 addr,
 
 	ret = _sunxi_rsb_run_xfer(rsb);
 	if (ret)
-		goto out;
+		goto unlock;
 
 	*buf = readl(rsb->regs + RSB_DATA);
 
+unlock:
 	mutex_unlock(&rsb->lock);
 
-out:
 	return ret;
 }