From: Haishuang Yan Date: Thu, 15 Jun 2017 02:29:29 +0000 (+0800) Subject: ip_tunnel: fix potential issue in ip_tunnel_rcv X-Git-Tag: v4.12-rc7~24^2~18 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=469f87e158628fe66dcbbce9dd5e7b7acfe934a9;p=uclinux-h8%2Flinux.git ip_tunnel: fix potential issue in ip_tunnel_rcv When ip_tunnel_rcv fails, the tun_dst won't be freed, so call dst_release to free it in error code path. Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") Acked-by: Eric Dumazet Acked-by: Pravin B Shelar Tested-by: Zhang Shengju Signed-off-by: Haishuang Yan Signed-off-by: David S. Miller --- diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index b436d0775631..129d1a3616f8 100644 --- a/net/ipv4/ip_tunnel.c +++ b/net/ipv4/ip_tunnel.c @@ -446,6 +446,8 @@ int ip_tunnel_rcv(struct ip_tunnel *tunnel, struct sk_buff *skb, return 0; drop: + if (tun_dst) + dst_release((struct dst_entry *)tun_dst); kfree_skb(skb); return 0; }