From: David S. Miller Date: Mon, 3 Dec 2018 23:20:19 +0000 (-0800) Subject: Merge branch 'phy-micrel-toggling-reset' X-Git-Tag: v4.20-rc6~1^2~27 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=4763c9f926d8907beaacea4fd883c784696d84ef;p=uclinux-h8%2Flinux.git Merge branch 'phy-micrel-toggling-reset' Yoshihiro Shimoda says: ==================== net: phy: micrel: add toggling phy reset This patch set is for R-Car Gen3 Salvator-XS boards. If we do the following method, the phy cannot link up correctly. 1) Kernel boots by using initramfs. --> No open the nic, so phy_device_register() and phy_probe() deasserts the reset. 2) Kernel enters the suspend. --> So, keep the reset signal as deassert. --> On R-Car Salvator-XS board, unfortunately, the board power is turned off. 3) Kernel returns from suspend. 4) ifconfig eth0 up --> Then, since edge signal of the reset doesn't happen, it cannot link up. 5) ifconfig eth0 down 6) ifconfig eth0 up --> In this case, it can link up. When resolving this issue after I got feedback from Andrew and Heiner, I found an issue that the phy_device.c didn't call phy_resume() if the PHY was not attached. So, patch 1 fixes it and add toggling the phy reset to the micrel phy driver. Changes from v1 (as RFC): - No remove the current code of phy_device.c to avoid any side effects. - Fix the mdio_bus_phy_resume() in phy_device.c. - Add toggling the phy reset in micrel.c if the PHY is not attached. ==================== Signed-off-by: David S. Miller --- 4763c9f926d8907beaacea4fd883c784696d84ef