From: Javier Martinez Canillas Date: Wed, 19 Aug 2015 11:19:57 +0000 (+0200) Subject: i2c: Replace I2C_CROS_EC_TUNNEL dependency X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=480b141abf7ffe630016dd4ced0fc57f105a05a9;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git i2c: Replace I2C_CROS_EC_TUNNEL dependency The ChromeOS EC tunnel I2C bus driver depend on CROS_EC_PROTO but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends on is bad practice as it may lead to circular Kconfig dependencies. Since the platform device that is matched with the I2C bus driver is registered by the ChromeOS EC mfd driver, I2C_CROS_EC_TUNNEL really depends on MFD_CROS_EC. And because this config option selects CROS_EC_PROTO, that dependency is met as well. So make the driver to depend on MFD_CROS_EC instead of CROS_EC_PROTO. Signed-off-by: Javier Martinez Canillas Signed-off-by: Wolfram Sang --- diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 48f4b796003c..08b86178e8fb 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -1140,7 +1140,7 @@ config I2C_SIBYTE config I2C_CROS_EC_TUNNEL tristate "ChromeOS EC tunnel I2C bus" - depends on CROS_EC_PROTO + depends on MFD_CROS_EC help If you say yes here you get an I2C bus that will tunnel i2c commands through to the other side of the ChromeOS EC to the i2c bus