From: Markus Armbruster <armbru@redhat.com>
Date: Thu, 6 Mar 2014 09:12:53 +0000 (+0100)
Subject: qdev-monitor-test: Don't test human-readable error message
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=49649f23db977137c031a21eee2f0521404f6710;p=qmiga%2Fqemu.git

qdev-monitor-test: Don't test human-readable error message

Test the error class instead.  Expecting a specific message is
fragile.  In fact, it broke once already, in commit 75884af.  Restore
the test of error member "class" dropped there, and drop the test of
error member "desc".

There are no other tests of "desc" as far as I can tell.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---

diff --git a/tests/qdev-monitor-test.c b/tests/qdev-monitor-test.c
index eefaab823a..e20ffd67a7 100644
--- a/tests/qdev-monitor-test.c
+++ b/tests/qdev-monitor-test.c
@@ -32,9 +32,7 @@ static void test_device_add(void)
                    "}}");
     g_assert(response);
     error = qdict_get_qdict(response, "error");
-    g_assert_cmpstr(qdict_get_try_str(error, "desc"),
-                    ==,
-                    "Device needs media, but drive is empty");
+    g_assert_cmpstr(qdict_get_try_str(error, "class"), ==, "GenericError");
     QDECREF(response);
 
     /* Delete the drive */