From: Willy Tarreau Date: Sun, 11 Nov 2007 15:47:50 +0000 (+0100) Subject: [PATCH] PPP: fix crash using usb-serial on high speed devices X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=5031521d8fe44ed6e5953ae88861a693ef1e847d;hp=ee731f57c03a321e73eb700a06e9c0172d505ffa;p=linux-kernel-docs%2Flinux-2.4.36.git [PATCH] PPP: fix crash using usb-serial on high speed devices Problem discussed here and reported and tracked by Gilles Espinasse : https://sourceforge.net/tracker/index.php?func=detail&aid=1678777&group_id=40604&atid=428519 Patch and description provided by David W Studeman : "...This patch prevents the kernel from crashing during uploads with some 3G devices. On my XU870, certain irc rooms would cause my machine to crash and reboot. This also happened with the Nozomi drivers and the Option GT Max when uploading torrents. Neither happen anymore with the ppp_async patched driver." On linux-ppp, James Cameron confirmed to Gilles that the patch fixes the hangs problem for him : http://marc.info/?l=linux-ppp&m=118711617415737&w=2 --- diff --git a/drivers/net/ppp_async.c b/drivers/net/ppp_async.c index 836ca051..512433d6 100644 --- a/drivers/net/ppp_async.c +++ b/drivers/net/ppp_async.c @@ -624,7 +624,7 @@ ppp_async_encode(struct asyncppp *ap) *buf++ = PPP_FLAG; ap->olim = buf; - kfree_skb(ap->tpkt); + dev_kfree_skb_any(ap->tpkt); ap->tpkt = 0; return 1; }