From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 23 May 1999 21:41:14 +0000 (+0000)
Subject: Detect case of invalid use of GROUP BY when there are no
X-Git-Tag: REL9_0_0~25385
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=505b5185fc37a53fbdcd27e26f163fb0c532d136;p=pg-rex%2Fsyncrep.git

Detect case of invalid use of GROUP BY when there are no
aggregate functions, as in
	select a, b from foo group by a;
The ungrouped reference to b is not kosher, but formerly we neglected to
check this unless there was an aggregate function somewhere in the query.
---

diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c
index 23158f3751..14c8150ff0 100644
--- a/src/backend/parser/analyze.c
+++ b/src/backend/parser/analyze.c
@@ -5,7 +5,7 @@
  *
  * Copyright (c) 1994, Regents of the University of California
  *
- *  $Id: analyze.c,v 1.106 1999/05/17 17:03:27 momjian Exp $
+ *  $Id: analyze.c,v 1.107 1999/05/23 21:41:14 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -373,7 +373,7 @@ transformInsertStmt(ParseState *pstate, InsertStmt *stmt)
 										  qry->uniqueFlag);
 
 	qry->hasAggs = pstate->p_hasAggs;
-	if (pstate->p_hasAggs)
+	if (pstate->p_hasAggs || qry->groupClause)
 		parseCheckAggregates(pstate, qry);
 
 	/*
@@ -997,7 +997,7 @@ transformSelectStmt(ParseState *pstate, SelectStmt *stmt)
 	qry->rtable = pstate->p_rtable;
 
 	qry->hasAggs = pstate->p_hasAggs;
-	if (pstate->p_hasAggs)
+	if (pstate->p_hasAggs || qry->groupClause)
 		parseCheckAggregates(pstate, qry);
 
 	/*
diff --git a/src/backend/parser/parse_agg.c b/src/backend/parser/parse_agg.c
index ab00040c65..19dd98dfbe 100644
--- a/src/backend/parser/parse_agg.c
+++ b/src/backend/parser/parse_agg.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_agg.c,v 1.19 1999/05/12 15:01:48 wieck Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_agg.c,v 1.20 1999/05/23 21:41:14 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -173,28 +173,34 @@ tleIsAggOrGroupCol(TargetEntry *tle, List *groupClause, List *tlist)
 }
 
 /*
- * parseCheckAggregates -
- *	  this should really be done earlier but the current grammar
- *	  cannot differentiate functions from aggregates. So we have do check
- *	  here when the target list and the qualifications are finalized.
+ * parseCheckAggregates
+ *	Check for aggregates where they shouldn't be and improper grouping.
+ *
+ *	Ideally this should be done earlier, but it's difficult to distinguish
+ *	aggregates from plain functions at the grammar level.  So instead we
+ *	check here.  This function should be called after the target list and
+ *	qualifications are finalized.
  */
 void
 parseCheckAggregates(ParseState *pstate, Query *qry)
 {
 	List	   *tl;
 
-	Assert(pstate->p_hasAggs);
+	/* This should only be called if we found aggregates or grouping */
+	Assert(pstate->p_hasAggs || qry->groupClause);
 
 	/*
-	 * aggregates never appear in WHERE clauses. (we have to check where
-	 * clause first because if there is an aggregate, the check for
-	 * non-group column in target list may fail.)
+	 * Aggregates must never appear in WHERE clauses.
+	 * (Note this check should appear first to deliver an appropriate
+	 * error message; otherwise we are likely to generate the generic
+	 * "illegal use of aggregates in target list" message, which is
+	 * outright misleading if the problem is in WHERE.)
 	 */
 	if (contain_agg_clause(qry->qual))
 		elog(ERROR, "Aggregates not allowed in WHERE clause");
 
 	/*
-	 * the target list can only contain aggregates, group columns and
+	 * The target list can only contain aggregates, group columns and
 	 * functions thereof.
 	 */
 	foreach(tl, qry->targetList)
@@ -214,7 +220,6 @@ parseCheckAggregates(ParseState *pstate, Query *qry)
 	if (!exprIsAggOrGroupCol(qry->havingQual, qry->groupClause, qry->targetList))
 		elog(ERROR,
 			 "Illegal use of aggregates or non-group column in HAVING clause");
-	return;
 }