From: Dan Carpenter Date: Wed, 23 Sep 2015 11:00:59 +0000 (+0300) Subject: drm/amdgpu: integer overflow in amdgpu_mode_dumb_create() X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=54ef0b5461c071050c61e501af5544842d61f40a;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git drm/amdgpu: integer overflow in amdgpu_mode_dumb_create() args->size is a u64. arg->pitch and args->height are u32. The multiplication will overflow instead of using the high 32 bits as intended. Reviewed-by: Christian König Signed-off-by: Dan Carpenter Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c index b82fab2cc888..7297ca3a0ba7 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c @@ -659,7 +659,7 @@ int amdgpu_mode_dumb_create(struct drm_file *file_priv, int r; args->pitch = amdgpu_align_pitch(adev, args->width, args->bpp, 0) * ((args->bpp + 1) / 8); - args->size = args->pitch * args->height; + args->size = (u64)args->pitch * args->height; args->size = ALIGN(args->size, PAGE_SIZE); r = amdgpu_gem_object_create(adev, args->size, 0,