From: Axel Lin Date: Wed, 30 Jul 2014 03:13:52 +0000 (+0800) Subject: hwmon: (ads1015) Fix off-by-one for valid channel index checking X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=56de1377ad92f72ee4e5cb0faf7a9b6048fdf0bf;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git hwmon: (ads1015) Fix off-by-one for valid channel index checking Current code uses channel as array index, so the valid channel value is 0 .. ADS1015_CHANNELS - 1. Signed-off-by: Axel Lin Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c index 7f9dc2f86b63..22e0c926989d 100644 --- a/drivers/hwmon/ads1015.c +++ b/drivers/hwmon/ads1015.c @@ -198,7 +198,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client) } channel = be32_to_cpup(property); - if (channel > ADS1015_CHANNELS) { + if (channel >= ADS1015_CHANNELS) { dev_err(&client->dev, "invalid channel index %d on %s\n", channel, node->full_name);