From: Al Viro Date: Mon, 12 Nov 2012 06:19:02 +0000 (-0500) Subject: kill bogus BUG_ON() in do_close_on_exec() X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=5a8477660d9ddc090203736d7271137265cb25bb;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git kill bogus BUG_ON() in do_close_on_exec() It can be legitimately triggered via procfs access. Now, at least 2 of 3 of get_files_struct() callers in procfs are useless, but when and if we get rid of those we can always add WARN_ON() here. BUG_ON() at that spot is simply wrong. Signed-off-by: Al Viro --- diff --git a/fs/file.c b/fs/file.c index d3b5fa80b71b..331e7d24d9d3 100644 --- a/fs/file.c +++ b/fs/file.c @@ -685,7 +685,6 @@ void do_close_on_exec(struct files_struct *files) struct fdtable *fdt; /* exec unshares first */ - BUG_ON(atomic_read(&files->count) != 1); spin_lock(&files->file_lock); for (i = 0; ; i++) { unsigned long set;