From: Colin Ian King Date: Fri, 23 Mar 2018 22:53:50 +0000 (+0000) Subject: batman-adv: don't pass a NULL hard_iface to batadv_hardif_put X-Git-Tag: v4.17-rc7~7^2~3^2~3 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=65cc02a8e1d4449daedf3a84e9dfdda2e44a5d97;p=uclinux-h8%2Flinux.git batman-adv: don't pass a NULL hard_iface to batadv_hardif_put In the case where hard_iface is NULL, the error path may pass a null pointer to batadv_hardif_put causing a null pointer dereference error. Avoid this by only calling the function if hard_iface not null. Detected by CoverityScan, CID#1466456 ("Explicit null dereferenced") Fixes: 53dd9a68ba68 ("batman-adv: add multicast flags netlink support") Signed-off-by: Colin Ian King Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index a11d3d89f012..a35f597e8c8b 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -1536,7 +1536,7 @@ out: if (!ret && primary_if) *primary_if = hard_iface; - else + else if (hard_iface) batadv_hardif_put(hard_iface); return ret;