From: Brian <brian@yutani.localnet.net>
Date: Fri, 11 May 2007 21:50:33 +0000 (-0600)
Subject: comment about fixing uniform structs
X-Git-Tag: android-x86-1.6~1863^2~122
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=6a587c01242b6227658ea1160efa34a221d52368;p=android-x86%2Fexternal-mesa.git

comment about fixing uniform structs
---

diff --git a/src/mesa/shader/slang/slang_codegen.c b/src/mesa/shader/slang/slang_codegen.c
index 60ffc48f54b..02260d3422e 100644
--- a/src/mesa/shader/slang/slang_codegen.c
+++ b/src/mesa/shader/slang/slang_codegen.c
@@ -2866,6 +2866,19 @@ _slang_codegen_global_variable(slang_assemble_ctx *A, slang_variable *var,
          if (datatype == GL_NONE) {
             if (var->type.specifier.type == SLANG_SPEC_STRUCT) {
                _mesa_problem(NULL, "user-declared uniform structs not supported yet");
+               /* XXX what we need to do is unroll the struct into its
+                * basic types, creating a uniform variable for each.
+                * For example:
+                * struct foo {
+                *   vec3 a;
+                *   vec4 b;
+                * };
+                * uniform foo f;
+                *
+                * Should produce uniforms:
+                * "f.a"  (GL_FLOAT_VEC3)
+                * "f.b"  (GL_FLOAT_VEC4)
+                */
             }
             else {
                slang_info_log_error(A->log,