From: Kevin Wolf Date: Fri, 15 Dec 2017 10:54:22 +0000 (+0100) Subject: block: Document that x-blockdev-change breaks quorum children list X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=6b4738ce4d32d551b37afb387813a37a24b6de8f;p=qmiga%2Fqemu.git block: Document that x-blockdev-change breaks quorum children list Removing a quorum child node with x-blockdev-change results in a quorum driver state that cannot be recreated with create options because it would require a list with gaps. This causes trouble in at least .bdrv_refresh_filename(). Document this problem so that we won't accidentally mark the command stable without having addressed it. Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia --- diff --git a/qapi/block-core.json b/qapi/block-core.json index a8cdbc300b..e94a6881b2 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -3918,6 +3918,10 @@ # does not support all kinds of operations, all kinds of children, nor # all block drivers. # +# FIXME Removing children from a quorum node means introducing gaps in the +# child indices. This cannot be represented in the 'children' list of +# BlockdevOptionsQuorum, as returned by .bdrv_refresh_filename(). +# # Warning: The data in a new quorum child MUST be consistent with that of # the rest of the array. #