From: Andreas Schwab Date: Tue, 12 Jun 2018 17:26:36 +0000 (+0200) Subject: RISC-V: fix R_RISCV_ADD32/R_RISCV_SUB32 relocations X-Git-Tag: v4.18-rc4~25^2~4 X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=781c8fe2da3d2c7c95cd7ffddbab63b80a79da4d;p=uclinux-h8%2Flinux.git RISC-V: fix R_RISCV_ADD32/R_RISCV_SUB32 relocations The R_RISCV_ADD32/R_RISCV_SUB32 relocations should add/subtract the address of the symbol (without overflow check), not its contents. Signed-off-by: Andreas Schwab Signed-off-by: Palmer Dabbelt --- diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c index 1d5e9b934b8c..6bb48315c973 100644 --- a/arch/riscv/kernel/module.c +++ b/arch/riscv/kernel/module.c @@ -263,14 +263,14 @@ static int apply_r_riscv_align_rela(struct module *me, u32 *location, static int apply_r_riscv_add32_rela(struct module *me, u32 *location, Elf_Addr v) { - *(u32 *)location += (*(u32 *)v); + *(u32 *)location += (u32)v; return 0; } static int apply_r_riscv_sub32_rela(struct module *me, u32 *location, Elf_Addr v) { - *(u32 *)location -= (*(u32 *)v); + *(u32 *)location -= (u32)v; return 0; }