From: Christian Gromm Date: Mon, 22 Jun 2020 08:48:12 +0000 (+0200) Subject: staging: most: cdev: remove overcautious parameter checking X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=7aed13d1653678137ef291ced45158eaa8c39e96;p=uclinux-h8%2Flinux.git staging: most: cdev: remove overcautious parameter checking The interface pointer passed to a component API function cannot be NULL. This patch removes unnecessary sanity checks of the pointer. Signed-off-by: Christian Gromm Link: https://lore.kernel.org/r/1592815695-19305-4-git-send-email-christian.gromm@microchip.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/most/cdev/cdev.c b/drivers/staging/most/cdev/cdev.c index 394c7621cb51..9fc84fae21fd 100644 --- a/drivers/staging/most/cdev/cdev.c +++ b/drivers/staging/most/cdev/cdev.c @@ -324,9 +324,6 @@ static int comp_disconnect_channel(struct most_interface *iface, int channel_id) { struct comp_channel *c; - if (!iface) - return -EINVAL; - c = get_channel(iface, channel_id); if (!c) return -ENXIO; @@ -391,9 +388,6 @@ static int comp_tx_completion(struct most_interface *iface, int channel_id) { struct comp_channel *c; - if (!iface) - return -EINVAL; - c = get_channel(iface, channel_id); if (!c) return -ENXIO; @@ -426,7 +420,7 @@ static int comp_probe(struct most_interface *iface, int channel_id, int retval; int current_minor; - if ((!iface) || (!cfg) || (!name)) + if ((!cfg) || (!name)) return -EINVAL; c = get_channel(iface, channel_id);