From: kernel test robot <lkp@intel.com>
Date: Thu, 20 Aug 2020 10:20:51 +0000 (+0200)
Subject: selinux: fix memdup.cocci warnings
X-Git-Tag: v5.10-rc1~159^2~15
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=879229311bc8a887f00d827525ea59f23861c1ad;p=tomoyo%2Ftomoyo-test1.git

selinux: fix memdup.cocci warnings

Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: c7c556f1e81b ("selinux: refactor changing booleans")
CC: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
---

diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
index 05c7a10e0aab..0b32f3ab025e 100644
--- a/security/selinux/ss/conditional.c
+++ b/security/selinux/ss/conditional.c
@@ -686,12 +686,11 @@ static int cond_bools_copy(struct hashtab_node *new, struct hashtab_node *orig,
 {
 	struct cond_bool_datum *datum;
 
-	datum = kmalloc(sizeof(struct cond_bool_datum), GFP_KERNEL);
+	datum = kmemdup(orig->datum, sizeof(struct cond_bool_datum),
+			GFP_KERNEL);
 	if (!datum)
 		return -ENOMEM;
 
-	memcpy(datum, orig->datum, sizeof(struct cond_bool_datum));
-
 	new->key = orig->key; /* No need to copy, never modified */
 	new->datum = datum;
 	return 0;