From: James Teh <jamie@jantrid.net>
Date: Fri, 17 Jun 2011 05:32:15 +0000 (+1000)
Subject: NVDAObjects.IAccessible.MSHTML.locateHTMLElementByID: It's not possible to get an... 
X-Git-Tag: jpdev130418~1573
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=8953f68a25a21c0d5f185b2b9d99c8d1b900f095;p=nvdajp%2Fnvdajp.git

NVDAObjects.IAccessible.MSHTML.locateHTMLElementByID: It's not possible to get an IAccessible for an iframe with an ARIA role of presentation, so just skip it.
Fixes NotImplementedError exceptions on pages containing such iframes.
Fixes #1569.
---

diff --git a/source/NVDAObjects/IAccessible/MSHTML.py b/source/NVDAObjects/IAccessible/MSHTML.py
index 8522c0403..af635a98a 100644
--- a/source/NVDAObjects/IAccessible/MSHTML.py
+++ b/source/NVDAObjects/IAccessible/MSHTML.py
@@ -120,7 +120,12 @@ def locateHTMLElementByID(document,ID):
 		log.debugWarning("document.getElementsByTagName failed with COMError %s"%e)
 		return None
 	for frame in frames:
-		pacc=IAccessibleFromHTMLNode(frame)
+		try:
+			pacc=IAccessibleFromHTMLNode(frame)
+		except NotImplementedError:
+			# #1569: It's not possible to get an IAccessible from frames marked with an ARIA role of presentation.
+			# In this case, just skip this frame.
+			continue
 		res=IAccessibleHandler.accChild(pacc,1)
 		if not res: continue
 		childElement=HTMLNodeFromIAccessible(res[0])
diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
index 3d34d5df0..d77e7877c 100644
--- a/user_docs/en/changes.t2t
+++ b/user_docs/en/changes.t2t
@@ -94,7 +94,8 @@ Highlights of this release include major improvements concerning punctuation and
 - Fixed the issue in NVDA's Voice Settings dialog where the value of sliders was sometimes not reported when changed. (#1411)
 - NVDA no longer fails to announce the new cell when moving in an Excel spreadsheet after cutting and pasting. (#1567)
 - NVDA no longer becomes worse at guessing color names the more colors it announces.
-  
+- In Internet Explorer and other MSHTML controls, fixed the inability to read parts of rare pages which contain iframes marked with an ARIA role of presentation. (#1569)
+
 
 == Changes for Developers ==
 - Developer documentation can now be generated using SCons. See readme.txt at the root of the source distribution for details, including associated dependencies.