From: Yong Ding Date: Fri, 24 Nov 2017 10:12:21 +0000 (+0800) Subject: soc: qcom: hab: add some code clean up X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=8ad90a3cf781bb90e9e37abce320b49b37aec3f0;p=sagit-ice-cold%2Fkernel_xiaomi_msm8998.git soc: qcom: hab: add some code clean up Add some code clean up for hab driver, including removing implicit type conversion, and etc. Change-Id: Ic2910f48063e22d1708972c1e0a5d23cbf179874 Signed-off-by: Yong Ding --- diff --git a/drivers/soc/qcom/hab/hab_mem_linux.c b/drivers/soc/qcom/hab/hab_mem_linux.c index 84709ed5c242..a69a7571a0f6 100644 --- a/drivers/soc/qcom/hab/hab_mem_linux.c +++ b/drivers/soc/qcom/hab/hab_mem_linux.c @@ -269,7 +269,7 @@ long habmem_imp_hyp_map(void *imp_ctx, uint32_t userflags) { struct page **pages; - struct compressed_pfns *pfn_table = impdata; + struct compressed_pfns *pfn_table = (struct compressed_pfns *)impdata; struct pages_list *pglist; struct importer_context *priv = imp_ctx; unsigned long pfn; diff --git a/drivers/soc/qcom/hab/khab.c b/drivers/soc/qcom/hab/khab.c index f7499773ae42..05e6aa2fa7ca 100644 --- a/drivers/soc/qcom/hab/khab.c +++ b/drivers/soc/qcom/hab/khab.c @@ -117,7 +117,7 @@ int32_t habmm_import(int32_t handle, void **buff_shared, uint32_t size_bytes, param.flags = flags; ret = hab_mem_import(hab_driver.kctx, ¶m, 1); - if (!IS_ERR(ret)) + if (!ret) *buff_shared = (void *)(uintptr_t)param.kva; return ret;