From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Date: Fri, 23 Jun 2017 13:09:24 +0000 (+0900)
Subject: pcm: minor code cleanup for ioctl call
X-Git-Tag: android-x86-9.0-r1~298
X-Git-Url: http://git.osdn.net/view?a=commitdiff_plain;h=8beab3eb8a4346f823cb42c507122f0abbf9025f;p=android-x86%2Fexternal-alsa-lib.git

pcm: minor code cleanup for ioctl call

When error occurs, return value from ioctl(2) is -1 and error code can
be got thread local variable, errno. It's OK just to check the return
value without any assignment.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/src/pcm/pcm_hw.c b/src/pcm/pcm_hw.c
index f0efcde3..de6fd1af 100644
--- a/src/pcm/pcm_hw.c
+++ b/src/pcm/pcm_hw.c
@@ -132,8 +132,7 @@ static int sync_ptr1(snd_pcm_hw_t *hw, unsigned int flags)
 {
 	int err;
 	hw->sync_ptr->flags = flags;
-	err = ioctl((hw)->fd, SNDRV_PCM_IOCTL_SYNC_PTR, (hw)->sync_ptr);
-	if (err < 0) {
+	if (ioctl(hw->fd, SNDRV_PCM_IOCTL_SYNC_PTR, hw->sync_ptr) < 0) {
 		err = -errno;
 		SYSMSG("SNDRV_PCM_IOCTL_SYNC_PTR failed (%i)", err);
 		return err;